Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain id abi calls #320

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Add chain id abi calls #320

merged 4 commits into from
Dec 22, 2023

Conversation

sydhds
Copy link
Contributor

@sydhds sydhds commented Dec 11, 2023

No description provided.

@sydhds sydhds mentioned this pull request Dec 12, 2023
Closed
@sydhds sydhds requested a review from Leo-Besancon December 12, 2023 16:20
@sydhds sydhds marked this pull request as ready for review December 12, 2023 16:20
@sydhds sydhds requested a review from modship December 12, 2023 16:20
modship
modship previously approved these changes Dec 12, 2023
View reviewed changes
Leo-Besancon
Leo-Besancon previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Approved with two comments.

Cargo.toml Outdated Show resolved Hide resolved
src/as_execution/abi.rs Outdated Show resolved Hide resolved
@sydhds sydhds dismissed stale reviews from Leo-Besancon and modship via f256165 December 13, 2023 13:40
@sydhds sydhds requested a review from Leo-Besancon December 13, 2023 13:41
@sydhds sydhds added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit d1dce67 Dec 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damip damip damip approved these changes

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

@modship modship modship left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sydhds @modship @damip @Leo-Besancon